Re: walsender.c comment with no context is hard to understand

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: walsender.c comment with no context is hard to understand
Date: 2024-06-27 05:43:54
Message-ID: Znz8GsfRVgYDOFb2@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 26, 2024 at 02:30:26PM +0530, vignesh C wrote:
> On Mon, 3 Jun 2024 at 11:21, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>> Perhaps the comment should say something like it used to:
>> /* Fail if there is not enough WAL available. This can happen during
>> shutdown. */
>
> Agree with this, +1 for this change.

That would be an improvement. Would you like to send a patch with all
the areas you think could stand for improvements?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2024-06-27 06:09:22 Re: thread-safety: gmtime_r(), localtime_r()
Previous Message Michael Paquier 2024-06-27 05:39:21 Re: libpq: Fix lots of discrepancies in PQtrace