From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: CheckMyDatabase some error messages in two lines. |
Date: | 2024-06-10 23:22:46 |
Message-ID: | ZmeKxgZ760tlzvBP@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Jun 09, 2024 at 10:12:53PM -0400, Tom Lane wrote:
> No doubt. People have done it both ways in the past, but I think
> currently there's a weak consensus in favor of using one line for
> such messages even when it runs past 80 columns, mainly because
> that makes it easier to grep the source code for a message text.
I recall the same consensus here. Greppability matters across the
board.
> But: I don't see too much value in changing this particular instance,
> because the line break is in a place where it would not likely cause
> you to miss finding the line. You might grep for the first part of
> the string or the second part, but probably not for ", which is not".
> If the line break were in the middle of a phrase, there'd be more
> argument for collapsing it out.
Not sure these ones are worth it, either, so I'd let them be.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Jeff Davis | 2024-06-10 23:47:28 | Re: Improve the granularity of PQsocketPoll's timeout parameter? |
Previous Message | John H | 2024-06-10 22:51:05 | Allow logical failover slots to wait on synchronous replication |