| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, a(dot)kozhemyakin(at)postgrespro(dot)ru, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #18483: Segmentation fault in tests modules |
| Date: | 2024-06-17 05:29:05 |
| Message-ID: | Zm_JoQRXNe6nWb7N@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Mon, Jun 10, 2024 at 02:50:33PM +0900, Michael Paquier wrote:
> On Sun, Jun 09, 2024 at 03:00:00PM +0300, Alexander Lakhin wrote:
>> 4)
>> I guess, make_tuple_indirect() could be improved with:
>> /* only work on existing, not-null varlenas */
>> if (TupleDescAttr(tupdesc, i)->attisdropped ||
>> nulls[i] ||
>> - TupleDescAttr(tupdesc, i)->attlen != -1)
>> + TupleDescAttr(tupdesc, i)->attlen != -1 ||
>> + TupleDescAttr(tupdesc, i)->attstorage == TYPSTORAGE_PLAIN)
>
> Fun. True enough that this function is only here for toastable
> values, so that makes sense.
This one was indeed simple enough, so fixed it for now.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Bug reporting form | 2024-06-17 05:44:18 | BUG #18513: PG17 build on windows generates postgres.exe.lib instead of postgres.lib |
| Previous Message | Tom Lane | 2024-06-16 23:30:46 | Re: BUG #18499: Reindexing spgist index concurrently triggers Assert("TransactionIdIsValid(state->myXid)") |