Re: error "can only drop stats once" brings down database

From: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Floris Van Nee <florisvannee(at)optiver(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: error "can only drop stats once" brings down database
Date: 2024-06-06 06:05:11
Message-ID: ZmFRlwr/53/tXqxn@ip-10-97-1-34.eu-west-3.compute.internal
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Hi,

On Thu, Jun 06, 2024 at 01:44:26PM +0900, Michael Paquier wrote:
> On Wed, Jun 05, 2024 at 10:31:04AM +0000, Floris Van Nee wrote:
> > This patch would help in getting more info about this specific issue
> > if it reoccurs, but in that case it's only helpful if it's
> > backpatched.
> > Agree the refcount addition makes sense.
>
> Adding Bertrand in CC as he was similarly playing with this area.
>
> What would both of you think about the attached. This is a mix of
> what's been proposed on the two threads, with the addition of the
> refcount.

I like the idea of adding refcount in the error message. OTOH I think it's more
appropriate to make use of errdetail_internal() as proposed in [1], but that's
a nit.

[1]: https://www.postgresql.org/message-id/ZkRsoOMrSrNI945i%40ip-10-97-1-34.eu-west-3.compute.internal

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2024-06-06 07:12:08 BUG #18496: Strange Handling for Circular Views and Permissions in PostgreSQL
Previous Message David Rowley 2024-06-06 05:04:36 Re: BUG #18477: A specific SQL query with "ORDER BY ... NULLS FIRST" is performing poorly if an ordering column is n