| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Xing Guo <higuoxing(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Fix an incorrect assertion condition in mdwritev(). |
| Date: | 2024-06-05 04:10:41 |
| Message-ID: | Zl_lQQVprXdvhrZH@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 03, 2024 at 03:24:07PM -0700, Andres Freund wrote:
> I'm confused - isn't using common/int.h entirely sufficient for that? Nearly
> all architectures have more efficient ways to check for 64bit overflows than
> doing actual 128 bit math.
One simple way to change the assertion would be something like that, I
assume. Andres, does it answer your concerns?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| assert_mdwritev.patch | text/x-diff | 977 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2024-06-05 04:12:41 | Re: Fix use of possible uninitialized variable retval (src/pl/plpgsql/src/pl_handler.c) |
| Previous Message | Amit Kapila | 2024-06-05 03:43:26 | Re: Logical Replication of sequences |