Re: Fix an incorrect assertion condition in mdwritev().

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Xing Guo <higuoxing(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Fix an incorrect assertion condition in mdwritev().
Date: 2024-06-03 22:43:41
Message-ID: Zl5HHSTW__JUui1h@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 03, 2024 at 03:24:07PM -0700, Andres Freund wrote:
> I'm confused - isn't using common/int.h entirely sufficient for that? Nearly
> all architectures have more efficient ways to check for 64bit overflows than
> doing actual 128 bit math.

Oh, right. We could just plug in pg_add_u32_overflow here. Funny
thing is that I'm the one who committed these toys with
__builtin_add_overflow(), still nobody has found a case where this one
would be useful. At least until now.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2024-06-03 22:47:43 Re: POC: GROUP BY optimization
Previous Message Andres Freund 2024-06-03 22:24:07 Re: Fix an incorrect assertion condition in mdwritev().