Re: allow changing autovacuum_max_workers without restarting

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: "Imseih (AWS), Sami" <simseih(at)amazon(dot)com>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: allow changing autovacuum_max_workers without restarting
Date: 2024-06-03 18:52:29
Message-ID: Zl4Q7YGslvdL0eYj@nathan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 16, 2024 at 09:16:46PM -0500, Nathan Bossart wrote:
> On Thu, May 16, 2024 at 04:37:10PM +0000, Imseih (AWS), Sami wrote:
>> I thought 256 was a good enough limit. In practice, I doubt anyone will
>> benefit from more than a few dozen autovacuum workers.
>> I think 1024 is way too high to even allow.
>
> WFM

Here is an updated patch that uses 256 as the upper limit.

>> I don't think combining 1024 + 5 = 1029 is a good idea in docs.
>> Breaking down the allotment and using the name of the constant
>> is much more clear.

I plan to further improve this section of the documentation in v18, so I've
left the constant unexplained for now.

--
nathan

Attachment Content-Type Size
v4-0001-allow-changing-autovacuum_max_workers-without-res.patch text/plain 17.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2024-06-03 18:58:11 Re: Proposal: Document ABI Compatibility
Previous Message David E. Wheeler 2024-06-03 18:43:17 Proposal: Document ABI Compatibility