Re: Postgres and --config-file option

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Aleksander Alekseev <aleksander(at)timescale(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Subject: Re: Postgres and --config-file option
Date: 2024-05-15 02:07:21
Message-ID: ZkQY2fOaI3QfhdH3@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, May 14, 2024 at 03:03:58PM +0300, Aleksander Alekseev wrote:
> Here is the patch v4 with fixed typo ("geoq"). Per off-list feedback
> from Alvaro - thanks!

+ <option>-c name=value</option> command-line parameter, or its equivalent
+ <option>--name=value</option> variation. For example,
<programlisting>
-postgres -c log_connections=yes -c log_destination='syslog'
+postgres -c log_connections=yes --log-destination='syslog'

Wow. I've used -c many times, and never noticed that this was a
supported option switch. There's always something to learn around
here..

- printf(_(" -c NAME=VALUE set run-time parameter\n"));
+ printf(_(" -c NAME=VALUE set run-time parameter (see also --NAME)\n"));
[...]
- printf(_(" --NAME=VALUE set run-time parameter\n"));
+ printf(_(" --NAME=VALUE set run-time parameter, a shorter form of -c\n"));
[...]
- to set multiple parameters.
+ to set multiple parameters. See the <option>--name</option>
+ option below for an alternate syntax.
[...]
- Sets a named run-time parameter; a shorter form of
- <option>-c</option>.
+ Sets the named run-time parameter; a shorter form of
+ <option>-c</option>. See <xref linkend="runtime-config"/>
+ for a listing of parameters.

Not sure that these additions in --help or the docs are necessary.
The rest looks OK.

- "You must specify the --config-file or -D invocation "
+ "You must specify the --config-file (or equivalent -c) or -D invocation "

How about "You must specify the --config-file, -c
\"config_file=VALUE\" or -D invocation"? There is some practice for
--opt=VALUE in .po files.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2024-05-15 02:13:00 Re: explain format json, unit for serialize and memory are different.
Previous Message Bruce Momjian 2024-05-15 02:06:17 Re: First draft of PG 17 release notes