| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Subject: | Re: BitmapHeapScan streaming read user and prelim refactoring |
| Date: | 2024-05-14 06:18:16 |
| Message-ID: | ZkMCKPlQlMwcwYGY@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, May 13, 2024 at 10:05:03AM -0400, Melanie Plageman wrote:
> Remove the assert and reset the field on which it previously asserted to
> avoid incorrectly emitting NULL-filled tuples from a previous scan on
> rescan.
> - Assert(scan->rs_empty_tuples_pending == 0);
> + scan->rs_empty_tuples_pending = 0;
Perhaps this should document the reason why the reset is done in these
two paths rather than let the reader guess it? And this is about
avoiding emitting some tuples from a previous scan.
> +SET enable_indexonlyscan = off;
> +set enable_indexscan = off;
> +SET enable_seqscan = off;
Nit: adjusting the casing of the second SET here.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2024-05-14 06:19:54 | Re: I have an exporting need... |
| Previous Message | David Rowley | 2024-05-14 06:16:26 | Re: explain format json, unit for serialize and memory are different. |