Re: Fix src/test/subscription/t/029_on_error.pl test when wal_debug is enabled

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Ilyasov Ian <ianilyasov(at)outlook(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, "a(dot)voloshin(at)postgrespro(dot)ru" <a(dot)voloshin(at)postgrespro(dot)ru>
Subject: Re: Fix src/test/subscription/t/029_on_error.pl test when wal_debug is enabled
Date: 2024-05-23 05:26:12
Message-ID: Zk7TdJHQZCRmOFQt@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 22, 2024 at 02:24:37PM +0000, Ilyasov Ian wrote:
> I corrected my patch according to what I think
> Michael wanted. I attached the new patch to the letter.

Thanks for compiling this patch. Yes, that's the idea.

- qr/processing remote data for replication origin \"pg_\d+\" during message type "INSERT" for replication target relation "public.tbl" in transaction \d+, finished at ([[:xdigit:]]+\/[[:xdigit:]]+)/
+ qr/ERROR: duplicate key.*\n.*DETAIL:.*\n.*CONTEXT:.* finished at ([[:xdigit:]]+\/[[:xdigit:]]+)/m

There are three CONTEXT strings that could map to this context. It
seems to me that we should keep the 'for replication target relation
"public.tbl" in transaction \d+,', before the "finished at" so as it
is possible to make a difference with the context that has a column
name and the context where there is no target relation. That makes
the regexp longer, but it is not that bad.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hayato Kuroda (Fujitsu) 2024-05-23 05:26:38 RE: Pgoutput not capturing the generated columns
Previous Message Will Mortensen 2024-05-23 05:21:53 Re: [PATCH] LockAcquireExtended improvement