| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Subject: | Re: Disallow changing slot's failover option in transaction block |
| Date: | 2024-04-18 23:34:49 |
| Message-ID: | ZiGuGZuuwnFfH8TL@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 18, 2024 at 11:22:24AM +0530, Amit Kapila wrote:
> +1 for option 2 as it sounds logical to me and consistent with ALTER
> SUBSCRIPTION. BTW, IIUC, you are referring to: "When altering the
> slot_name, the failover and two_phase property values of the named
> slot may differ from the counterpart failover and two_phase parameters
> specified in the subscription. When creating the slot, ensure the slot
> properties failover and two_phase match their counterpart parameters
> of the subscription." in docs [1], right?
FWIW, I'd also favor option 2, mostly on consistency ground as it
would offer a better user-experience. On top of that, you're saying
that may lead to some simplifications in the CREATE path. Without a
patch, it's hard to tell, though.
As far as I can see, this is not tracked as an open item and it should
be. So I have added one.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Steele | 2024-04-18 23:36:28 | Re: pg_combinebackup does not detect missing files |
| Previous Message | Michael Paquier | 2024-04-18 23:28:52 | Re: Support a wildcard in backtrace_functions |