From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: plenty code is confused about function level static |
Date: | 2024-04-18 23:20:18 |
Message-ID: | ZiGqsgW1rbqfyu6U@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Apr 18, 2024 at 07:56:35PM +0200, Peter Eisentraut wrote:
> On 18.04.24 19:11, Andres Freund wrote:
>> Thoughts about when to apply these? Arguably they're fixing mildly broken
>> code, making it appropriate to fix in 17, but it's also something that we
>> could end up fixing for a while...
>
> Yeah, let's keep these for later. They are not regressions, and there is no
> end in sight yet. I have some other related stuff queued up, so if we're
> going to start adjusting these kinds of things now, it would open a can of
> worms.
This is a set of optimizations for stuff that has accumulated across
the years in various code paths, so I'd vote on the side of caution
and wait until v18 opens for business.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | David Steele | 2024-04-18 23:22:42 | Re: pg_combinebackup fails on file named INCREMENTAL.* |
Previous Message | Thomas Munro | 2024-04-18 22:36:22 | Re: cfbot is failing all tests on FreeBSD/Meson builds |