| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Weird test mixup |
| Date: | 2024-03-18 06:13:41 |
| Message-ID: | ZffblQnhTivQH9q6@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 18, 2024 at 10:50:25AM +0500, Andrey M. Borodin wrote:
> Maybe consider function injection_points_attach_local(‘point name’)
> instead of static switch?
> Or even injection_points_attach_global(‘point name’), while function
> injection_points_attach(‘point name’) will be global? This would
> favour writing concurrent test by default…
The point is to limit accidents like the one of this thread. So, for
cases already in the tree, not giving the point name in the SQL
function would be simple enough.
What you are suggesting can be simply done, as well, though I'd rather
wait for a reason to justify doing so.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2024-03-18 06:27:56 | Re: What about Perl autodie? |
| Previous Message | Michael Paquier | 2024-03-18 06:08:02 | Re: Switching XLog source from archive to streaming when primary available |