| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | walther(at)technowledgy(dot)de |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Christophe Pettus <xof(at)thebuild(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Bugs <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Regression tests fail with musl libc because libpq.so can't be loaded |
| Date: | 2024-03-22 19:44:28 |
| Message-ID: | Zf3fnKpHIGpe5mOi@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Fri, Mar 22, 2024 at 09:36:19AM -0400, Bruce Momjian wrote:
> On Fri, Mar 22, 2024 at 09:33:38AM +0100, walther(at)technowledgy(dot)de wrote:
> > Bruce Momjian:
> > > I suggest we use the #ifdef test to continue our existing behavior for
> > > the libraries we know about, like glibc, and use the LD_* process title
> > > truncation hack for libc's we don't recognize.
> > >
> > > Attached is a prototype patch which implements this based on previous
> > > patches.
> >
> > The condition to check for linux/glibc in your patch is slightly off:
> >
> > #if ! defined(__linux__) || (! defined(__GLIBC__) && defined(__UCLIBC__ ))
> >
> > should be
> >
> > #if defined(__linux__) && ! (defined(__GLIBC__) || defined(__UCLIBC__ ))
> >
> > With the latter, it passes tests with musl.
>
> Yes, my logic was wrong. Not sure what I was thinking, frankly.
>
> I am not a big fan of negating a complex conditional, but would rather
> pass the negation into the conditional, new patch attached.
With no one "hoping this patch dies in a fire"*, I have updated it with
more details, which I now think is committable to master. Is this
something to backpatch? Seems too rare a bug to me.
* Robert Haas, https://www.postgresql.org/message-id/CA%2BTgmoYsyrCNmg%2BYh6rgP7K8r-bYPjCeF1tPxENRFwD4VZAZvw%40mail.gmail.com
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
| Attachment | Content-Type | Size |
|---|---|---|
| proctitle.diff | text/x-diff | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2024-03-23 00:39:36 | Re: [BUG] false positive in bt_index_check in case of short 4B varlena datum |
| Previous Message | Noah Misch | 2024-03-22 19:43:23 | Re: relfrozenxid may disagree with row XIDs after 1ccc1e05ae |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2024-03-22 19:58:59 | Re: SET ROLE documentation improvement |
| Previous Message | Kartyshov Ivan | 2024-03-22 19:42:52 | Re: [HACKERS] make async slave to wait for lsn to be replayed |