Re: Avoid is possible a expensive function call (src/backend/utils/adt/varlena.c)

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Cc: Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Avoid is possible a expensive function call (src/backend/utils/adt/varlena.c)
Date: 2024-03-04 22:53:09
Message-ID: ZeZQ1TWRWX9TKjCY@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 04, 2024 at 03:08:03PM -0300, Ranier Vilela wrote:
> I can't see any user validation at the function pg_newlocale_from_collation.

Matthias is right, look closer. I can see more than one check,
especially note the one related to the collation version mismatch that
should not be silently ignored.

> meson test pass all checks.

Collations are harder to test because they depend on the environment
where the test happens, especially with ICU.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2024-03-04 23:13:38 Re: a wrong index choose when statistics is out of date
Previous Message Nathan Bossart 2024-03-04 22:49:26 Re: Adding deprecation notices to pgcrypto documentation