| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Sutou Kouhei <kou(at)clear-code(dot)com> |
| Cc: | andres(at)anarazel(dot)de, sawada(dot)mshk(at)gmail(dot)com, zhjwpku(at)gmail(dot)com, andrew(at)dunslane(dot)net, nathandbossart(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Make COPY format extendable: Extract COPY TO format implementations |
| Date: | 2024-03-01 05:31:38 |
| Message-ID: | ZeFoOprWyKU6gpkP@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 22, 2024 at 06:39:48PM +0900, Sutou Kouhei wrote:
> If so, adding the change independently on HEAD makes
> sense. But I don't know why that improves
> performance... Inlining?
I guess so. It does not make much of a difference, though. The thing
is that the dispatch caused by the custom callbacks called for each
row is noticeable in any profiles I'm taking (not that much in the
worst-case scenarios, still a few percents), meaning that this impacts
the performance for all the in-core formats (text, csv, binary) as
long as we refactor text/csv/binary to use the routines of copyapi.h.
I don't really see a way forward, except if we don't dispatch the
in-core formats to not impact the default cases. That makes the code
a bit less elegant, but equally efficient for the existing formats.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2024-03-01 05:38:21 | Re: DOCS: Avoid using abbreviation "aka" |
| Previous Message | Jelte Fennema-Nio | 2024-03-01 05:30:10 | Re: Improve readability by using designated initializers when possible |