| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add lookup table for replication slot invalidation causes |
| Date: | 2024-02-22 06:56:09 |
| Message-ID: | ZdbwCVjCfFdbV7oa@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 22, 2024 at 05:30:08PM +1100, Peter Smith wrote:
> Oops. Perhaps I meant more like below -- in any case, the point was
> the same -- to ensure RS_INVAL_NONE is what returns if something
> unexpected happens.
You are right that this could be a bit confusing, even if we should
never reach this state. How about avoiding to return the index of the
loop as result, as of the attached? Would you find that cleaner?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| slot-reason.patch | text/x-diff | 742 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrei Lepikhov | 2024-02-22 07:04:55 | Re: POC: GROUP BY optimization |
| Previous Message | shveta malik | 2024-02-22 06:46:34 | Re: Synchronizing slots from primary to standby |