| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Japin Li <japinli(at)hotmail(dot)com> |
| Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Improve readability by using designated initializers when possible |
| Date: | 2024-02-27 06:25:35 |
| Message-ID: | Zd2AXzSPghHV4zmE@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Feb 26, 2024 at 05:00:13PM +0800, Japin Li wrote:
> On Mon, 26 Feb 2024 at 16:41, jian he <jian(dot)universality(at)gmail(dot)com> wrote:
>> obvious typo errors.
These would cause compilation failures. Saying that, this is a very
nice cleanup, so I've fixed these and applied the patch after checking
that the one-one replacements were correct.
About 0002, I can't help but notice pg_enc2icu_tbl and
pg_enc2gettext_tb. There are exceptions like MULE_INTERNAL, but is it
possible to do better?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2024-02-27 07:10:12 | Re: More new SQL/JSON item methods |
| Previous Message | Kyotaro Horiguchi | 2024-02-27 06:07:09 | Re: A failure in t/001_rep_changes.pl |