From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru> |
Cc: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
Subject: | Re: Injection points: some tools to wait and wake |
Date: | 2024-02-26 23:29:53 |
Message-ID: | Zd0e8SAwwA4U5UW_@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Feb 26, 2024 at 02:10:49PM +0500, Andrey M. Borodin wrote:
> So that we could do something like
>
> ok(node_standby->await_injection_point(“CreateRestartPoint”,”checkpointer"));
It would be more flexible with a full string to describe the test
rather than a process name in the second argument.
> IMO, this could make many tests cleaner.
> Or, perhaps, it’s a functionality for a future development?
This could just happen as separate refactoring, I guess. But I'd wait
to see if more tests requiring scans to pg_stat_activity pop up. For
example, the test just posted here does not rely on that:
https://www.postgresql.org/message-id/ZdyZya4YrNapWKqz@ip-10-97-1-34.eu-west-3.compute.internal
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Ivan Trofimov | 2024-02-26 23:31:02 | Re: libpq: PQfnumber overload for not null-terminated strings |
Previous Message | Stephen Frost | 2024-02-26 23:28:42 | Re: [PATCH] updates to docs about HOT updates for BRIN |