| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Majid Garoosi <amoomajid99(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: GUC-ify walsender MAX_SEND_SIZE constant |
| Date: | 2024-02-09 05:20:27 |
| Message-ID: | ZcW2G0-i81TR10Iw@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 08, 2024 at 02:42:00PM +0330, Majid Garoosi wrote:
> Thank you very much for your review.
Something to be aware of, but the community lists use bottom-posting
for replies because it is easier to follow the logic of a thread this
way. See here:
https://en.wikipedia.org/wiki/Posting_style#Bottom-posting
> I generally agree with your suggestions, so just applied them.
> You can find the new patch in the attached file.
Thanks for the patch, that looks rather fine. I have spent some time
polishing the docs, adding a mention that increasing the value can
show benefits depending on what you do. How does the attached look to
you?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Introduce-wal_sender_max_send_size-as-a-GUC.patch | text/x-diff | 8.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-02-09 05:26:34 | Re: [PATCH] Add native windows on arm64 support |
| Previous Message | Michael Paquier | 2024-02-09 04:40:43 | Re: Make COPY format extendable: Extract COPY TO format implementations |