From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
Cc: | Anton Voloshin <a(dot)voloshin(at)postgrespro(dot)ru>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: 039_end_of_wal: error in "xl_tot_len zero" test |
Date: | 2024-02-15 04:28:56 |
Message-ID: | Zc2TCE7wiSVq6qTC@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Jan 19, 2024 at 11:35:30AM +1300, Thomas Munro wrote:
> On Fri, Jan 19, 2024 at 1:47 AM Anton Voloshin
> <a(dot)voloshin(at)postgrespro(dot)ru> wrote:
>> I believe there is a small problem in the 039_end_of_wal.pl's
>> "xl_tot_len zero" test. It supposes that after immediate shutdown the
>> server, upon startup recovery, should always produce a message matching
>> "invalid record length at .*: wanted 24, got 0". However, if the
>> circumstances are just right and we happened to hit exactly on the edge
>> of WAL page, then the message on startup recovery would be "invalid
>> magic number 0000 in log segment .*, offset .*". The test does not take
>> that into account.
>
> Thanks for figuring this out! Right, I see. I will look more closely
> when I'm back from summer vacation in a few days, but first reaction:
Thomas, are you planning to look at that?
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2024-02-15 04:29:27 | Re: index prefetching |
Previous Message | Robert Haas | 2024-02-15 04:16:30 | Re: logical decoding and replication of sequences, take 2 |