From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Tender Wang <tndrwang(at)gmail(dot)com> |
Cc: | Yongtao Huang <yongtaoh2022(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
Subject: | Re: BUG #18310: Some SQL commands fail to process duplicate objects with error: tuple already updated by self |
Date: | 2024-01-30 01:14:58 |
Message-ID: | ZbhNktmvYQXQRAob@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
On Mon, Jan 29, 2024 at 11:27:15AM +0800, Tender Wang wrote:
> Michael Paquier <michael(at)paquier(dot)xyz> 于2024年1月29日周一 07:18写道:
>> Yes, incorrect indentation is something I have noticed in the previous
>> patches you have sent to the lists: all the new lines have an
>> incorrect indentation. See here, where it is mentioned that the code
>> base uses 4 column tab spacing with tabs preserved:
>> https://www.postgresql.org/docs/devel/source-format.html
>>
>> FWIW, I am OK for simple patches, but this is going to make reviews
>> harder when it comes to read more complicated patches that touch more
>> code paths.
>>
>
> Sorry, my mistake. Thanks for reminding. Yongtao has help me fix the
> indentation issue in his patch,
> and I don't have new code to add.
The latest version posted on [1] was still not right. I got a lot of
complaints from a simple `git diff --check`. I am just looking at the
patch, no need to send something else.
[1]: https://www.postgresql.org/message-id/CAHewXNk5yeUo2XPaqTYSfbkKhEBfKd4VYa7NHv2MzV-mJ9ULpA@mail.gmail.com
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2024-01-30 06:28:33 | Re: BUG #18310: Some SQL commands fail to process duplicate objects with error: tuple already updated by self |
Previous Message | Alexander Korotkov | 2024-01-29 21:45:24 | Re: v17 Possible Union All Bug |