Re: BUG #18310: Some SQL commands fail to process duplicate objects with error: tuple already updated by self

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Yongtao Huang <yongtaoh2022(at)gmail(dot)com>
Cc: Tender Wang <tndrwang(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #18310: Some SQL commands fail to process duplicate objects with error: tuple already updated by self
Date: 2024-01-28 23:18:21
Message-ID: ZbbgvVe_xbi-1U6n@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Sun, Jan 28, 2024 at 01:32:08AM +0800, Yongtao Huang wrote:
> Hi Tender Wang,
>
> I think your code changes *LGTM*. Thanks for your contribution.

Yes, incorrect indentation is something I have noticed in the previous
patches you have sent to the lists: all the new lines have an
incorrect indentation. See here, where it is mentioned that the code
base uses 4 column tab spacing with tabs preserved:
https://www.postgresql.org/docs/devel/source-format.html

FWIW, I am OK for simple patches, but this is going to make reviews
harder when it comes to read more complicated patches that touch more
code paths.

> Broadcom Greenplum

Glad to see you're still alive and around.
--
Michael

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2024-01-28 23:34:02 Re: BUG #18310: Some SQL commands fail to process duplicate objects with error: tuple already updated by self
Previous Message Yongtao Huang 2024-01-27 17:32:08 Re: BUG #18310: Some SQL commands fail to process duplicate objects with error: tuple already updated by self