Re: Use of backup_label not noted in log

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: David Steele <david(at)pgmasters(dot)net>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
Subject: Re: Use of backup_label not noted in log
Date: 2024-01-26 00:52:17
Message-ID: ZbMCQWbjTyj1r0en@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 25, 2024 at 08:56:52AM -0400, David Steele wrote:
> I would still advocate for a back patch here. It is frustrating to get logs
> from users that just say:
>
> LOG: invalid checkpoint record
> PANIC: could not locate a valid checkpoint record
>
> It would be very helpful to know what the checkpoint record LSN was in this
> case.

Yes, I've pested over this one in the past when debugging corruption
issues. To me, this would just mean to appens to the PANIC an "at
%X/%X", but perhaps you have more in mind for these code paths?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Wei Wang (Fujitsu) 2024-01-26 01:17:06 RE: Fix inappropriate comments in function ReplicationSlotAcquire
Previous Message Yugo NAGATA 2024-01-26 00:42:45 Rename setup_cancel_handler in pg_dump