| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | David Steele <david(at)pgmasters(dot)net> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> |
| Subject: | Re: Use of backup_label not noted in log |
| Date: | 2024-01-25 08:12:53 |
| Message-ID: | ZbIYBXIqxrH2MlhW@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 22, 2024 at 04:36:27PM +0900, Michael Paquier wrote:
> + if (ControlFile->backupStartPoint != InvalidXLogRecPtr)
>
> Nit 1: I would use XLogRecPtrIsInvalid here.
>
> + ereport(LOG,
> + (errmsg("completed backup recovery with redo LSN %X/%X",
> + LSN_FORMAT_ARGS(oldBackupStartPoint))));
>
> Nit 2: How about adding backupEndPoint in this LOG? That would give:
> "completed backup recovery with redo LSN %X/%X and end LSN %X/%X".
Hearing nothing, I've just applied a version of the patch with these
two modifications on HEAD. If this needs tweaks, just let me know.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2024-01-25 08:14:22 | Re: A compiling warning in jsonb_populate_record_valid |
| Previous Message | Sergey Prokhorenko | 2024-01-25 08:09:18 | Re: UUID v7 |