Re: Optimize duplicate code and fix memory leak in function fetch_remote_table_info()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Yongtao Huang <yongtaoh2022(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Optimize duplicate code and fix memory leak in function fetch_remote_table_info()
Date: 2024-01-20 03:13:43
Message-ID: Zas6Z_Fc-hafI5xG@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 19, 2024 at 10:42:46PM +0800, Yongtao Huang wrote:
> This patch fixes two things in the function fetch_remote_table_info().
>
> (1) *pfree(pub_names.data)* to avoid potential memory leaks.

True that this code puts some effort in cleaning up the memory used
locally.

> (2) 2 pieces of code can do the same work,
> ```
> I wanna integrate them into one function `make_pubname_list()` to make the
> code neater.

It does not strike me as a huge problem to let the code be as it is on
HEAD when building the lists, FWIW, as we are talking about two places
and there is clarity in keeping the code as it is.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2024-01-20 03:31:20 Re: MultiXact\SLRU buffers configuration
Previous Message Michael Paquier 2024-01-20 03:09:18 Re: fix stats_fetch_consistency value in postgresql.conf.sample