| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tristan Partin <tristan(at)neon(dot)tech> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Subject: | Re: Add pgindent test to check if codebase is correctly formatted |
| Date: | 2024-01-17 01:35:13 |
| Message-ID: | Zacu0ZfY-g95kSSU@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 16, 2024 at 07:32:47PM -0600, Tristan Partin wrote:
> It requires changes to at least the Meson build files. pg_bsd_indent is not
> marked for installation currently. There is a TODO there. pgindent has no
> install_data() for instance. pg_bsd_indent seemingly gets installed
> somewhere in autotools given the contents of its Makefile, but I didn't see
> anything in my install tree afterward.
>
> Sure RPM/DEB packagers can solve this issue downstream, but that doesn't
> help those of that run "meson install" or "make install" upstream. Packagers
> are probably more likely to package the tools if they are marked for
> installation by upstream too.
>
> Hope this helps to better explain what changes would be required within the
> Postgres source tree.
Yes, it does, thanks.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2024-01-17 01:36:13 | Re: New Window Function: ROW_NUMBER_DESC() OVER() ? |
| Previous Message | Tristan Partin | 2024-01-17 01:32:47 | Re: Add pgindent test to check if codebase is correctly formatted |