| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add pg_get_injection_points() for information of injection points |
| Date: | 2025-04-15 05:44:38 |
| Message-ID: | Z_3yRgmFn7Y9V-uw@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 15, 2025 at 02:49:24AM +0000, Hayato Kuroda (Fujitsu) wrote:
> Should cur_pos be uint32 instead of int? Either of them can work because
> cur_pos can be [0, 128], but it may be clearer.
>
> Apart from above, LGTM.
Sure, why not. Thanks for the review.
An important thing may be to split the change into two:
- First one for the API in injection_point.c.
- Second one for the new function.
The second patch is still something folks seem to be meh about, but if
the end consensus is to put the new SQL function in the module
injection_points we are going to need the first patch anyway.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Add-InjectionPointList-to-retrieve-list-of-inject.patch | text/plain | 3.5 KB |
| v3-0002-Add-pg_get_injection_points.patch | text/plain | 9.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2025-04-15 05:44:46 | Re: pg_dump --if-exists --clean when drop index that is partition of a partitioned index |
| Previous Message | jian he | 2025-04-15 05:33:09 | Re: pg_dump --if-exists --clean when drop index that is partition of a partitioned index |