Re: ci: Allow running mingw tests by default via environment variable

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Wolfgang Walther <walther(at)technowledgy(dot)de>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Tomas Vondra <tomas(at)vondra(dot)me>
Subject: Re: ci: Allow running mingw tests by default via environment variable
Date: 2025-04-14 22:30:29
Message-ID: Z_2MhRBKoLILCi5H@nathan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Apr 14, 2025 at 09:26:59PM +0200, Andres Freund wrote:
> On April 14, 2025 9:22:40 PM GMT+02:00, Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>>On Sat, Apr 12, 2025 at 08:18:35PM +1200, Thomas Munro wrote:
>>> Is it safe to assume that CI changes come under the same code-freeze
>>> exception as tests and docs? I would assume so, it's just scripting
>>> glue in .cirrus.XXX files not affecting one bit of the software, but I
>>> don't recall that we specifically clarified that before, so can
>>> someone from the RMT please +1 this? Then I'll go ahead and push
>>> these.
>>
>>That seems reasonable to me. But to play devil's advocate, is there a
>>strong reason for doing this before July?
>
> We get more coverage of the changes we merge until then.

Sure. To be clear, I think this change is fine to proceed, especially
given we're less than a week into feature freeze and have plenty of time to
stabilize any cfbot breakage. If anything, this change should _help_
stabilize v18. I do wonder if we should be more cautious about these kinds
of changes closer to release dates, but that's not a concern here.

--
nathan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Mahendra Singh Thalor 2025-04-14 22:55:42 Re: pgsql: Non text modes for pg_dumpall, correspondingly change pg_restore
Previous Message Mahendra Singh Thalor 2025-04-14 22:21:12 use correct variable in error message in _allocAH function (pg_backup_archiver.c)