| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add pg_get_injection_points() for information of injection points |
| Date: | 2025-04-14 12:32:29 |
| Message-ID: | Z_0AXS90lNpwW3pM@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 14, 2025 at 05:26:14PM +0500, Kirill Reshke wrote:
> Hi! I noticed you do not bump catalog version here, so i was a little
> confused with
> ```
> reshke=# SELECT name, library, function FROM pg_get_injection_points();
> ERROR: function pg_get_injection_points() does not exist
> ```
> for a while
Catalog version bumps are done by committers when code is committed.
When sending patches for reviews (this one is for July and v19),
including catversion bumps in the patches sent just leads to useless
code conflicts, so this should not be done when submitting something.
> Also, should we define pg_get_injection_points in the injection_points
> extension maybe?
As this is global for all libraries, that's not something I would add
there.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2025-04-14 12:36:20 | RE: doc patch: clarify the naming rule for injection_points |
| Previous Message | Kirill Reshke | 2025-04-14 12:26:14 | Re: Add pg_get_injection_points() for information of injection points |