Re: BUG #18259: Assertion in ExtendBufferedRelLocal() fails after no-space-left condition

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: tender wang <tndrwang(at)gmail(dot)com>
Cc: Richard Guo <guofenglinux(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: BUG #18259: Assertion in ExtendBufferedRelLocal() fails after no-space-left condition
Date: 2024-01-04 00:40:56
Message-ID: ZZX-mINwayto9zR8@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Wed, Jan 03, 2024 at 02:46:06PM +0800, tender wang wrote:
> We had better add more comments to eplain when enter if(found) {...}
> branch, and when enter the ‘else {...}' branch in
> ExtendBufferedRelLocal().

Like? I don't feel like there is a need for more documentation in
this area, but of course feel free to add anything you think would be
worth adding, either as a patch or as suggestions for such comments
for these specific code path branches.
--
Michael

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Amit Kapila 2024-01-04 06:27:42 Re: BUG #18267: Logical replication bug: data is not synchronized after Alter Publication.
Previous Message Devrim Gündüz 2024-01-03 21:53:26 Re: BUG #18268: Failed to validate GPG signature for pgdg-redhat-repo-42.0-38PGDG.noarch