Re: Remove unneeded PGDATABASE setting from TAP tests

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove unneeded PGDATABASE setting from TAP tests
Date: 2024-01-03 01:30:05
Message-ID: ZZS4nXRndoE3zC70@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jan 01, 2024 at 01:52:10PM +0530, Bharath Rupireddy wrote:
> Oh, yeah. We can remove that too, after all, PGDATABASE is being set
> to postgres the default database which PostgreSQL::Test::Cluster does
> set for us. I was earlier swayed by the comment atop the PGDATABASE
> setting in 011_clusterdb_all.pl. Attached is v2 patch with this
> change.

Thanks. Applied after keeping the comment in 011_clusterdb_all.pl,
rewording it a bit.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2024-01-03 01:39:46 Re: Track in pg_replication_slots the reason why slots conflict?
Previous Message Michael Paquier 2024-01-03 00:51:09 Re: pg_upgrade and logical replication