Re: Build versionless .so for Android

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Matthias Kuhn <matthias(at)opengis(dot)ch>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Build versionless .so for Android
Date: 2023-12-31 06:24:27
Message-ID: ZZEJG-GsPgy0GM3J@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Dec 31, 2023 at 06:08:04AM +0100, Matthias Kuhn wrote:
> In order to ship libpq on Android, it needs to be built without a version
> suffix on the .so file.
> The attached patch will make sure that no version is added when built for
> Android.

FWIW, I have mixed feelings about patching the code to treat
android-linux as an exception while changing nothing in the
documentation to explain why this is required. A custom patch may
serve you better here, and note that you did not even touch the meson
paths. See libpq_c_args in src/interfaces/libpq/meson.build as one
example. That's just my opinion, of course, still there are no
buildfarm members that would cover your patch.

> I was wondering if there are a) any comments on the approach and if I
> should be handed in for a commitfest (currently waiting for the cooldown
> period after account activation, I am not sure how long that is)

Such discussions are adapted in a commit fest entry. No idea if there
is a cooldown period after account creation before being able to touch
the CF app contents, though.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-12-31 06:28:46 Re: pg_stat_statements: more test coverage
Previous Message Tom Lane 2023-12-31 06:19:48 Re: Build versionless .so for Android