| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tristan Partin <tristan(at)neon(dot)tech> |
| Cc: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Bo Anderson <mail(at)boanderson(dot)me>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: SSL tests fail on OpenSSL v3.2.0 |
| Date: | 2023-11-27 23:53:45 |
| Message-ID: | ZWUsCSbEFU5G_FYN@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 27, 2023 at 12:33:49PM -0600, Tristan Partin wrote:
> - res = secure_raw_read(((Port *) BIO_get_data(h)), buf, size);
> + res = secure_raw_read(((Port *) BIO_get_app_data(h)), buf, size);
> BIO_clear_retry_flags(h);
> if (res <= 0)
Interesting. I have yet to look at that in details, but
BIO_get_app_data() exists down to 0.9.8, which is the oldest version
we need to support for stable branches. So that looks like a safe
bet.
> -#ifndef HAVE_BIO_GET_DATA
> -#define BIO_get_data(bio) (bio->ptr)
> -#define BIO_set_data(bio, data) (bio->ptr = data)
> -#endif
Shouldn't this patch do a refresh of configure.ac and remove the check
on BIO_get_data() if HAVE_BIO_GET_DATA is gone?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tristan Partin | 2023-11-28 00:00:00 | Re: SSL tests fail on OpenSSL v3.2.0 |
| Previous Message | Robert Haas | 2023-11-27 23:50:34 | Re: Partial aggregates pushdown |