Re: Simplify if/else logic of walsender CreateReplicationSlot

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Simplify if/else logic of walsender CreateReplicationSlot
Date: 2023-11-20 08:07:38
Message-ID: ZVsTykodhzhPQo1d@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 20, 2023 at 06:01:42PM +1100, Peter Smith wrote:
> While reviewing another patch I was looking at the walsender's static
> function CreateReplicationSlot
>
> I found that the current logic seemed to have some unnecessary if/else
> checking which can be simplified.

Good idea. What you are suggesting here improves the readability of
this code, so +1.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-11-20 08:30:31 Re: Use of backup_label not noted in log
Previous Message Michael Paquier 2023-11-20 08:03:28 Re: Remove MSVC scripts from the tree