Re: mxid_age() and age(xid) appear undocumented

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: mxid_age() and age(xid) appear undocumented
Date: 2023-11-14 00:43:18
Message-ID: ZVLCpnPPu4n-8Hp6@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 5, 2018 at 01:30:22PM -0700, Peter Geoghegan wrote:
> On Thu, Jul 5, 2018 at 12:36 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> > On Sun, Jul 1, 2018 at 11:18 PM, David Rowley
> > <david(dot)rowley(at)2ndquadrant(dot)com> wrote:
> >> I see d692308cf494f6126 mentions mxid_age() in passing, but there
> >> appears to be no formal definition of either of these functions.
> >>
> >> Should there be?
> >
> > It seems like a good idea to me.
>
> +1

I looked into this and all the 4-byte xid functions are marked as
deprecated for the 8-byte variants. I don't think documenting 4-byte
mxid_age() and age(xid) makes sense anymore, and I don't see their value
enough to create 8-byte versions, so I just added C comments that they
were undocumented, in the attached patch.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

Only you can decide what is important to you.

Attachment Content-Type Size
age.diff text/x-diff 616 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2023-11-14 00:47:36 Re: Lifetime of commit timestamps
Previous Message Andres Freund 2023-11-14 00:32:56 Re: pgsql: doc: fix wording describing the checkpoint_flush_after GUC