From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Remove MSVC scripts from the tree |
Date: | 2023-11-08 23:05:20 |
Message-ID: | ZUwUMMfXnajEU4_c@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Nov 08, 2023 at 09:41:19AM +0100, Peter Eisentraut wrote:
> I don't think we should rely on sed being there on Windows. Maybe it's true
> now on the handful of buildfarm/CI machines and early adopters, but do we
> have any indication that that is systematic or just an accident?
Or both? When doing builds based on MinGW in the past I vaguely
recall getting annoyed that I needed to look for sed as one thing, so
your suggestion could simplify the experience a bit.
> Since we definitely require Perl now, we could just as well use the Perl
> script and avoid this issue.
>
> Attached is a Perl version of the sed script, converted by hand (so not the
> super-verbose s2p thing). It's basically just the sed script with
> semicolons added and the backslashes in the regular expressions moved
> around. I think we could use something like that for all platforms now.
Sounds like a good idea to me now that perl is a hard requirement.
+1.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2023-11-08 23:13:42 | Re: speed up a logical replica setup |
Previous Message | David Christensen | 2023-11-08 23:01:38 | Re: Moving forward with TDE [PATCH v3] |