| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Possible typo in nodeAgg.c |
| Date: | 2023-11-03 00:49:32 |
| Message-ID: | ZURDnLIPVWXv0pVR@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 16, 2020 at 09:03:52AM +0000, Hou, Zhijie wrote:
> Hi
>
> In /src/backend/executor/nodeAgg.c
>
> I found the following comment still use work mem,
> Since hash_mem has been introduced, Is it more accurate to use hash_mem here ?
>
> @@ -1827,7 +1827,7 @@ hash_agg_set_limits(double hashentrysize, double input_groups, int used_bits,
> /*
> * Don't set the limit below 3/4 of hash_mem. In that case, we are at the
> * minimum number of partitions, so we aren't going to dramatically exceed
> - * work mem anyway.
> + * hash_mem anyway.
Can someone comment on this? Is the text change correct?
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2023-11-03 01:18:02 | Re: Three commit tips |
| Previous Message | David Rowley | 2023-11-02 23:38:26 | Re: Why is DEFAULT_FDW_TUPLE_COST so insanely low? |