Re: pgsql: Don't trust unvalidated xl_tot_len.

From: Christoph Berg <myon(at)debian(dot)org>
To: Thomas Munro <tmunro(at)postgresql(dot)org>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Don't trust unvalidated xl_tot_len.
Date: 2023-11-10 18:10:49
Message-ID: ZU5yKecW5yMKKhtp@msg.df7cb.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Re: Thomas Munro
> Don't trust unvalidated xl_tot_len.

> src/test/recovery/t/039_end_of_wal.pl | 460 ++++++++++++++++++++++++++++++++

I haven't investigated the details yet, and it's not affecting the
builds on apt.postgresql.org, but the Debian amd64 and i386 regression
tests just failed this test on PG13 (11 and 15 are ok):

t/039_end_of_wal.pl ..................
Dubious, test returned 2 (wstat 512, 0x200)
No subtests run
Test Summary Report
-------------------
t/039_end_of_wal.pl (Wstat: 512 Tests: 0 Failed: 0)
Non-zero exit status: 2
Parse errors: No plan found in TAP output
Files=26, Tests=254, 105 wallclock secs ( 0.10 usr 0.02 sys + 19.58 cusr 11.02 csys = 30.72 CPU)
Result: FAIL
make[2]: *** [Makefile:23: check] Error 1

https://salsa.debian.org/postgresql/postgresql/-/jobs/4910354
https://salsa.debian.org/postgresql/postgresql/-/jobs/4910355

Christoph

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Christoph Berg 2023-11-10 18:13:12 Re: pgsql: Don't trust unvalidated xl_tot_len.
Previous Message Peter Eisentraut 2023-11-10 10:57:53 pgsql: Fix whitespace

Browse pgsql-hackers by date

  From Date Subject
Next Message Christoph Berg 2023-11-10 18:13:12 Re: pgsql: Don't trust unvalidated xl_tot_len.
Previous Message Nathan Bossart 2023-11-10 17:50:04 Re: Improvements in pg_dump/pg_restore toc format and performances