Re: missing requirement on ccache in postgresql16-devel

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Greg Hennessy <greg(dot)hennessy(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org, Devrim Gündüz <devrim(at)gunduz(dot)org>
Subject: Re: missing requirement on ccache in postgresql16-devel
Date: 2023-10-25 18:36:50
Message-ID: ZTlgQp16bA70zQWu@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Wed, Oct 25, 2023 at 01:21:44PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > On Wed, Oct 25, 2023 at 11:25:15AM -0400, Greg Hennessy wrote:
> >> The file /usr/pgsql-16/lib/pgxs/src/Makefile.global has a reference
> >> to ccache but the rpm doesn't list this as a dependency. I would like
> >> to submit that it is a bug that it does not.
>
> > Uh, ccache is an _optional_ way to speed up compilation. It is not a
> > requirement/dependency.
>
> Yeah, but if the Makefile says "CC = ccache gcc" then anybody
> trying to build under PGXS will fail if they don't have ccache
> installed. So I think Greg has a point.

Well, the question is where can we see this file,
/usr/pgsql-16/lib/pgxs/src/Makefile.global? Who created it? What does
it contain?

Mine is built from Makefile.global.in, and has:

CC = ccache gcc

but I define CC='ccache gcc' before I run autoconf.

> On typical Red Hat setups, it's not necessary to mention ccache
> explicitly to use it; instead that's managed via PATH. For
> example, I have
>
> $ which gcc
> /usr/lib64/ccache/gcc
>
> $ ls -l /usr/lib64/ccache/gcc
> lrwxrwxrwx. 1 root root 16 May 21 09:35 /usr/lib64/ccache/gcc -> ../../bin/ccache

Oh, I have not done that. I like to know when ccache is being used.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

Only you can decide what is important to you.

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Thomas Munro 2023-10-25 21:23:03 Re: BUG #18168: Parallel worker failed to initialize: could not create inherited socket: error code 10106
Previous Message Tom Lane 2023-10-25 17:21:44 Re: missing requirement on ccache in postgresql16-devel