| From: | Christoph Berg <myon(at)debian(dot)org> |
|---|---|
| To: | Tommy Pavlicek <tommypav122(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, jian(dot)universality(at)gmail(dot)com |
| Subject: | Re: [PATCH] Extend ALTER OPERATOR to support adding commutator, negator, hashes, and merges |
| Date: | 2023-10-24 13:51:16 |
| Message-ID: | ZTfL1G1fBPQHVPWV@msg.df7cb.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Re: Tommy Pavlicek
> I've added another patch (0002-require_unused_neg_com-v1.patch) that
> prevents using a commutator or negator that's already part of a pair.
Hmm. I agree with the general idea of adding sanity checks, but this
might be overzealous:
This change is breaking pgsphere which has <@ @> operator pairs, but
for historical reasons also includes alternative spellings of these
operators (both called @ with swapped operand types) which now
explodes because we can't add them with the "proper" commutator and
negators declared (which point to the canonical <@ @> !<@ !@>
operators).
https://github.com/postgrespro/pgsphere/blob/master/pgs_moc_compat.sql.in
We might be able to simply delete the @ operators, but doesn't this
new check break the general possibility to have more than one spelling
for the same operator?
Christoph
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2023-10-24 13:53:00 | Re: run pgindent on a regular basis / scripted manner |
| Previous Message | Bruce Momjian | 2023-10-24 13:46:34 | Re: run pgindent on a regular basis / scripted manner |