| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Christoph Berg <myon(at)debian(dot)org> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Generate automatically code and documentation related to wait ev |
| Date: | 2023-10-18 23:45:18 |
| Message-ID: | ZTBuDsHd4NEhbowc@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Wed, Oct 18, 2023 at 05:59:19PM +0200, Christoph Berg wrote:
> I'm not entirely sure this is the commit to blame, but it's certainly
> close:
That would be in this area, thanks for the report.
> A Debian user is complaining that in PG17, the installed
> /usr/include/postgresql/17/server/utils/wait_event.h file is
> referencing utils/wait_event_types.h, but that file doesn't get
> installed by the (autoconf) build sytem.
On a fresh install of HEAD (3f9b1f26ca), I get:
$ cd $(pg_config --includedir-server)
$ find . -name wait_event.h
./utils/wait_event.h
$ find . -name wait_event_types.h
./utils/wait_event_types.h
But I have missed a piece related to VPATH builds for
wait_event_types.h in src/include/Makefile (see around probes.h).
Will fix as per the attached. Thanks for the report.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| waitevent-include.patch | text/x-diff | 667 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-10-19 00:43:09 | pgsql: Install wait_event_types.h in VPATH builds |
| Previous Message | Bruce Momjian | 2023-10-18 17:41:10 | pgsql: doc: PG 16 relnotes: fix spelling error |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2023-10-19 00:56:35 | Re: run pgindent on a regular basis / scripted manner |
| Previous Message | David G. Johnston | 2023-10-18 23:35:27 | Re: The danger of deleting backup_label |