| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | "'pgsql-hackers(at)lists(dot)postgresql(dot)org'" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove wal_level settings for subscribers in tap tests |
| Date: | 2023-10-18 06:39:16 |
| Message-ID: | ZS99lGjSOlMcc3gJ@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 18, 2023 at 02:59:52AM +0000, Hayato Kuroda (Fujitsu) wrote:
> While discussing [1], I found that in tap tests, wal_level was set to logical for
> subscribers too. The setting is not needed for subscriber side, and it may cause
> misunderstanding for newcomers. Therefore, I wanted to propose the patch which
> removes unnecessary "allows_streaming => 'logical'".
> I grepped with the string and checked the necessity of them one by one.
>
> How do you think?
>
> [1]: https://commitfest.postgresql.org/45/4273/
Hmm, okay. On top of your argument, this may be a good idea for a
different reason: it makes the tests a bit cheaper as "logical"
generates a bit more WAL. Still the gain is marginal.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2023-10-18 06:39:41 | Re: Oversight in reparameterize_path_by_child leading to executor crash |
| Previous Message | Michael Paquier | 2023-10-18 06:26:40 | Re: Test 026_overwrite_contrecord fails on very slow machines (under Valgrind) |