Re: BUG #18134: ROW_COUNT do not set to 0 when psql's \gset command get no rows returned

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Japin Li <japinli(at)hotmail(dot)com>, amutu(at)amutu(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #18134: ROW_COUNT do not set to 0 when psql's \gset command get no rows returned
Date: 2023-10-01 00:54:22
Message-ID: ZRjDPucJiWKDJnkf@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Sat, Sep 30, 2023 at 08:44:07PM -0400, Tom Lane wrote:
> Bigger-picture question: should we back-patch this, or just fix it in
> HEAD? It's wrong, but I'm not sure it's so obviously wrong that there
> could not be somebody depending on the existing behavior.

FWIW, I am not excited about a backpatch, so I would keep this as a
HEAD-only change. Sure, the existing behavior is incorrect, but it
would be more annoying to break somebody's script flow after a minor
release. And that's not critical.

(If you want to fix that yourself, please feel free. I can do that
tomorrow by myself but life keeps me busy today and I don't have any
room to keep an eye on the buildfarm.)
--
Michael

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2023-10-01 00:58:12 Re: BUG #18134: ROW_COUNT do not set to 0 when psql's \gset command get no rows returned
Previous Message Tom Lane 2023-10-01 00:44:07 Re: BUG #18134: ROW_COUNT do not set to 0 when psql's \gset command get no rows returned