| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Robert Haas <robertmhaas(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: XLog size reductions: Reduced XLog record header size for PG17 |
| Date: | 2023-09-26 23:51:26 |
| Message-ID: | ZRNufiVAa1nmIDk3@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 25, 2023 at 07:40:00PM +0200, Matthias van de Meent wrote:
> On Wed, 20 Sept 2023 at 07:06, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> #define COPY_HEADER_FIELD(_dst, _size) \
>> do { \
>> - if (remaining < _size) \
>> + if (remaining < (_size)) \
>> goto shortdata_err; \
>>
>> There are a couple of stylistic changes like this one, that I guess
>> could just use their own patch to make these macros easier to use.
>
> They actually fix complaints of my IDE, but are otherwise indeed stylistic.
Oh, OK. I just use an old-school terminal, but no objections in
changing these if they make life easier for some hackers. Still, that
feels independant of what you are proposing here.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-09-27 00:03:19 | Re: Could not run generate_unaccent_rules.py script when update unicode |
| Previous Message | Bruce Momjian | 2023-09-26 23:44:44 | Re: Correct the documentation for work_mem |