Re: Have better wording for snapshot file reading failure

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Have better wording for snapshot file reading failure
Date: 2023-09-15 05:20:59
Message-ID: ZQPpu3Hq9IoOFHR9@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Sep 14, 2023 at 05:33:35PM -0700, Andres Freund wrote:
> I'd probably just go for something like "snapshot \"%s\" does not exist",
> similar to what we report for unknown tables etc. Arguably changing the
> errcode to ERRCODE_UNDEFINED_OBJECT would make this more precise?

Good points. Updated as suggested in v2 attached.
--
Michael

Attachment Content-Type Size
snapmgr-import-error-v2.patch text/x-diff 2.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-09-15 05:26:16 Re: Bug fix for psql's meta-command \ev
Previous Message Hayato Kuroda (Fujitsu) 2023-09-15 03:15:12 RE: [PoC] pg_upgrade: allow to upgrade publisher node