| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Jacob Speidel <jacob(at)extrahop(dot)com>, Will Mortensen <will(at)extrahop(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #17973: Reinit of pgstats entry for dropped DB can break autovacuum daemon |
| Date: | 2023-09-01 03:31:09 |
| Message-ID: | ZPFa/bED0YZc0oE3@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Thu, Aug 31, 2023 at 07:56:13PM -0700, Nathan Bossart wrote:
> On Fri, Sep 01, 2023 at 10:08:57AM +0900, Michael Paquier wrote:
>> + /*
>> + * Now that we rechecked, we are certain to be connected to a database and
>> + * thus can set MyDatabaseId.
>> + */
>> + MyDatabaseId = dboid;
>
> Perhaps we should expand this comment to make it clear that some code
> depends on this to avoid races with concurrent database drops/renames.
Yeah, this could be a bit more detailed, mentioning the dependency
with the pgstat shutdown callback. How about appending the following
sentence in a second paragraph, say:
"Setting MyDatabaseId after rechecking the existence of the database
matters for instance with the shutdown callback of the shared
statistics, as pgstat_report_stat() will update database statistics
depending on MyDatabaseId."
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Romain MAZIÈRE | 2023-09-01 10:34:26 | Error on help in /src/bin/pg_basebackup/pg_basebackup.c |
| Previous Message | Nathan Bossart | 2023-09-01 02:56:13 | Re: BUG #17973: Reinit of pgstats entry for dropped DB can break autovacuum daemon |