| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, 'Dilip Kumar' <dilipbalaut(at)gmail(dot)com> |
| Subject: | Re: [PoC] pg_upgrade: allow to upgrade publisher node |
| Date: | 2023-09-12 03:57:16 |
| Message-ID: | ZP/hnAbrCQMSp6aQ@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 12, 2023 at 02:33:25AM +0000, Zhijie Hou (Fujitsu) wrote:
> 2.
> + if (*invalidated && SlotIsLogical(s) && IsBinaryUpgrade)
> + elog(ERROR, "Replication slots must not be invalidated during the upgrade.");
>
> I think normally the first letter is lowercase, and we can avoid the period.
Documentation is your friend:
https://www.postgresql.org/docs/current/error-style-guide.html
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-09-12 04:19:53 | Re: PSQL error: total cell count of XXX exceeded |
| Previous Message | Michael Paquier | 2023-09-12 03:55:44 | Re: PSQL error: total cell count of XXX exceeded |