| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Jacob Champion <jchampion(at)timescale(dot)com> |
| Cc: | jreidthompson(at)nc(dot)rr(dot)com, Joseph Koshakow <koshy44(at)gmail(dot)com>, Gurjeet Singh <gurjeet(at)singh(dot)im>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: DecodeInterval fixes |
| Date: | 2023-08-22 05:39:48 |
| Message-ID: | ZORKJMczV0BkmjGD@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jul 10, 2023 at 10:42:31AM -0700, Jacob Champion wrote:
> On Mon, Jul 10, 2023 at 10:19 AM Reid Thompson <jreidthompson(at)nc(dot)rr(dot)com> wrote:
>> I made a another pass through the separated patches, it looks good to
>> me.
>
> LGTM too. (Thanks Tom for the clarification on ECPG.)
+SELECT INTERVAL '42 days 2 seconds ago ago';
+SELECT INTERVAL '2 minutes ago 5 days';
[...]
+SELECT INTERVAL 'hour 5 months';
+SELECT INTERVAL '1 year months days 5 hours';
0002 and 0003 make this stuff fail, but isn't there a risk that this
breaks applications that relied on these accidental behaviors?
Assuming that this is OK makes me nervous.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-08-22 05:49:32 | Re: Testing autovacuum wraparound (including failsafe) |
| Previous Message | David Rowley | 2023-08-22 05:36:34 | Re: PG 16 draft release notes ready |