Re: BUG #18057: unaccent removes intentional spaces

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: martin(at)schlossarek(dot)me, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #18057: unaccent removes intentional spaces
Date: 2023-08-19 23:57:29
Message-ID: ZOFW6ZBerH/IBoTC@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Sat, Aug 19, 2023 at 12:30:04PM -0400, Tom Lane wrote:
> Yeah, we could extend the parsing rules that way. It would break
> any rules files that currently use double quote as a plain character,
> but it seems unlikely that there are any. In any case, as long as
> this wasn't back-patched I think such a change would be acceptable.

Okay, thanks. Note that we do use double-quotes as a translated
character in a few cases, but as long as these are only handled as a
single character we could be OK. Or actually, wouldn't it be better
to always force escaping even for double quotes listed as single
characters? Based on what unaccent.rules has, that's not necessary,
but it could simplify the python code generating the file or the C
parsing. For example, the existing '”' would become listed as "\"" in
our unaccent.rules.
--
Michael

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2023-08-20 00:08:26 Re: BUG #18057: unaccent removes intentional spaces
Previous Message Vik Fearing 2023-08-19 19:39:12 Re: BUG #18034: Accept the spelling "+infinity" in datetime input is not accurate